Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override std library during playback #2852

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

celinval
Copy link
Contributor

@celinval celinval commented Nov 1, 2023

We override a few std functions to improve verification time or verification results, however, those functions are quite helpful during concrete execution. Thus, avoid overriding functions when executing concrete playback.

Resolves #2850

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner November 1, 2023 23:44
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Nov 1, 2023
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
@celinval celinval enabled auto-merge (squash) November 2, 2023 17:52
@celinval celinval merged commit 0e4e241 into model-checking:main Nov 2, 2023
20 checks passed
jaisnan added a commit that referenced this pull request Nov 17, 2023
Upgrade version number to 0.41.0

The CHANGELOG changes are:

```
# What's Changed
* Fix setup for `aarch64-unknown-linux-gnu` platform by @adpaco-aws in #2864
* Do not override `std` library during playback by @celinval in #2852
* Fix docker build step in release workflow by @adpaco-aws in #2854
* Fix path-dependent failures in `assess-artifacts` test by @adpaco-aws in #2849
* Automatic toolchain upgrade to nightly-2023-11-11 by @github-actions in #2870

**Full Changelog**: kani-0.40.0...kani-0.41.0

### Breaking Changes

* Set minimum python to 3.7 in docker container and release action by @remi-delmas-3000 in #2879
* Delete `any_slice` which has been deprecated since Kani 0.38.0. by @zhassan-aws in #2860
```

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not override std functions when running concrete playback
3 participants