Use stable_mir api instead of internal api for analysis #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Nov 12, 2023
There was a problem hiding this comment.
That's awesome and quick! Thanks!
I think you'll need to initialize stable mir for this to work. For now, you can wrap the logic of theprint_stats in a closure, and invoke rustc_internal::run. Also, I forgot to mention, and I don't know if you've figured out already, but one way to test this code is to run Kani with --verbose.
|
Well I tried few things but It wasn't really clear to me which things supposed to fail and which things supposed to not fail, I run |
|
@ouz-a No worries. Feel free to ping me offline if you want to know more. The important thing was to see the report when you ran with --verbose. Thanks! |
celinval
approved these changes
Nov 14, 2023
ouz-a
force-pushed
the
smiryf_analysis
branch
from
1b09e16
to
a493fcc
Compare
celinval
reviewed
Nov 14, 2023
ouz-a
force-pushed
the
smiryf_analysis
branch
from
a493fcc
to
d4c51ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces several
stable_mirAPIs toKani. Previously, we relied on internal APIs to accomplish our goals. However, with the recent enhancements tostable_mir, we no longer need these internal APIs. This pull request hopefully marks the beginning of a migration towardsstable_mirforKani.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.