Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit suggestions and an explanation when CBMC runs out of memory #2885

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Emit suggestions and an explanation when CBMC runs out of memory #2885

merged 2 commits into from
Nov 20, 2023

Conversation

JustusAdam
Copy link
Contributor

Improves the error reported to the user when the system kills CBMC to reclaim memory.

Resolves #2715

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@JustusAdam JustusAdam requested a review from a team as a code owner November 19, 2023 04:13
celinval
celinval approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thanks.

As a future improvement we should create a wiki with different ways of improving the memory consumption and link it here.

@JustusAdam
Copy link
Contributor Author

That's great! Thanks.

As a future improvement we should create a wiki with different ways of improving the memory consumption and link it here.

I was thinking the same thing.

@JustusAdam
Copy link
Contributor Author

@celinval Since this is a benign change it's probably all right if I don't wait for a second review?

@adpaco-aws
Copy link
Contributor

adpaco-aws commented Nov 20, 2023 •
edited
Loading

@celinval Since this is a benign change it's probably all right if I don't wait for a second review?

You don't need to wait for a second review unless it's for an RFC. I'll merge it for you this time 😛

@adpaco-aws adpaco-aws merged commit b0301a3 into model-checking:main Nov 20, 2023
20 checks passed
@JustusAdam JustusAdam deleted the oom-error branch November 24, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CBMC failed with status 137
3 participants
@JustusAdam @adpaco-aws @celinval