Migrate rvalue and coercion module to use StableMIR
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Dec 12, 2023
adpaco-aws
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks, @celinval ! Looks good to me, please resolve the pending comments after the toolchain has been updated. Happy to take another look then if you want me to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration was fairly straight forward, most constructs have a 1:1 map from internal APIs to StableMIR APIs. I've also removed the
is_coroutine()and theis_box()methods fromty_stable, since they were added to the StableMIR APIs together with other type methods here: rust-lang/rust#118846.Call-outs
I'm publishing this PR as a draft till we update the toolchain to
nightly-2023-12-13, since we need rust-lang/rust#118846.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.