Migrate function, block and statement modules to StableMIR #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
smir-codegen-fn
branch
from
86e52d9
to
3c67bc2
Compare
adpaco-aws
reviewed
Dec 18, 2023
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
adpaco-aws
approved these changes
Dec 18, 2023
zhassan-aws
added a commit
that referenced
this pull request
Jan 9, 2024
These are the auto-generated release notes for comparison purposes: ## What's Changed * Automate cargo update without dependabot by @tautschnig in #2942 * Update nightly toolchain to toolchain-2023-12-15 by @celinval in #2948 * Automatic cargo update to 2023-12-18 by @github-actions in #2951 * Migrate function, block and statement modules to StableMIR by @celinval in #2947 * Update Rust toolchain to `nightly-2023-12-18` by @adpaco-aws in #2953 * Update the rust toolchain to 2023-12-20 by @celinval in #2961 * Migrate foreign function, compiler-interface and kani-middle modules to use StableMIR by @celinval in #2959 * Build CBMC with `cmake` in all "CBMC latest" jobs by @adpaco-aws in #2965 * Automatic cargo update to 2024-01-01 by @github-actions in #2964 * Automatic cargo update to 2024-01-08 by @github-actions in #2968 * Upgrade to 2024-01-08 rust toolchain by @zhassan-aws in #2969 **Full Changelog**: kani-0.43.0...kani-0.44.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate these modules to use StableMIR except for calls that depend on the function signature and ABI. Note that we shouldn't really be using function signature as captured here: #1365. So I suggest that we move to using the FnAbi as soon as we add that to StableMIR.
Call-out
This change depends on the new nightly due to rust-lang/rust#118927 fix. Keeping it as a draft until it's released.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.