-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2024-01-08 rust toolchain #2969
Upgrade to 2024-01-08 rust toolchain #2969
Conversation
Thanks for doing this, @zhassan-aws ! Do you have any remarks on the regression we saw in #2962? It looks like the change in program steps and VCCs is still there but it doesn't affect solving time in the latest CI run. |
The failure in the benchcomp run is due to an increase in the solver runtime for |
Interestingly, the failure we were seeing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, the failure we were seeing in
recovery::rtt_estimator::test::weighted_average_test
with the previous PR (#2962) is no longer occurring.
That's great! In that case, I'm fine with merging this update before it becomes more troublesome.
These are the auto-generated release notes for comparison purposes: ## What's Changed * Automate cargo update without dependabot by @tautschnig in #2942 * Update nightly toolchain to toolchain-2023-12-15 by @celinval in #2948 * Automatic cargo update to 2023-12-18 by @github-actions in #2951 * Migrate function, block and statement modules to StableMIR by @celinval in #2947 * Update Rust toolchain to `nightly-2023-12-18` by @adpaco-aws in #2953 * Update the rust toolchain to 2023-12-20 by @celinval in #2961 * Migrate foreign function, compiler-interface and kani-middle modules to use StableMIR by @celinval in #2959 * Build CBMC with `cmake` in all "CBMC latest" jobs by @adpaco-aws in #2965 * Automatic cargo update to 2024-01-01 by @github-actions in #2964 * Automatic cargo update to 2024-01-08 by @github-actions in #2968 * Upgrade to 2024-01-08 rust toolchain by @zhassan-aws in #2969 **Full Changelog**: kani-0.43.0...kani-0.44.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Relevant PRs:
Emitter
cleanups rust-lang/rust#119601DiagCtxt
API duplication rust-lang/rust#119146TyKind::Coroutine
rust-lang/rust#119174By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.