Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade toolchain to 2024-02-14 #3036

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

zhassan-aws
Copy link
Contributor

Upgrade toolchain to 2024-02-17. Relevant PRs:

rust-lang/rust#120872

rust-lang/rust#120594

Resolves #3028

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner February 20, 2024 17:26
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Feb 20, 2024
@zhassan-aws
Copy link
Contributor Author

I ran one of the failing perf-benchcomp tests locally (s2n-quic/quic/s2n-quic-core/inet::checksum::tests::differential), and observed a high degree of variance, so I think the failure is acceptable. I suspect the same applies to the other failing differential test.

Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@jaisnan jaisnan merged commit 72fd9f4 into model-checking:main Feb 20, 2024
19 of 20 checks passed
@zhassan-aws zhassan-aws deleted the toolchain-2024-02-14 branch February 20, 2024 19:04
jaisnan added a commit that referenced this pull request Feb 21, 2024
## What's Changed
* Upgrade toolchain to 2024-02-14 by @zhassan-aws in
#3036

**Full Changelog**:
kani-0.46.0...kani-0.47.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2024-02-10 failed
2 participants