Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert clap from arg parsing during setup #3078

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Mar 14, 2024

--help and --version commands were being overriden by clap, so we are going back to the simple parsing with the added logic for use-local-toolchain.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner March 14, 2024 19:30
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Mar 14, 2024
@jaisnan jaisnan changed the title Revert clap from arg parsing Revert clap from arg parsing during setup Mar 14, 2024
@celinval
Copy link
Contributor

I think we should unblock the release by merging this, but if you want to try re-adding clap later, you can disable the parser --help and --version

@jaisnan
Copy link
Contributor Author

jaisnan commented Mar 14, 2024

I think we should unblock the release by merging this, but if you want to try re-adding clap later, you can disable the parser --help and --version

Yeah, I just wanted to go to a quick solution we know works for sure. In the meanwhile, I'll try to refactor this change to use clap with those options.

@zhassan-aws zhassan-aws merged commit a52564d into model-checking:main Mar 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants