Function Contracts: Interior Mutability Tests #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2024 17:35
added 3 commits
July 17, 2024 19:27
feliperodri
requested changes
Jul 18, 2024
tests/expected/function-contract/interior-mutability/oncecell.rs
Outdated
Show resolved
Hide resolved
This comment should be included in the test cases. |
celinval
reviewed
Jul 18, 2024
celinval
reviewed
Jul 19, 2024
There was a problem hiding this comment.
I don't think you need the transmute in any of these cases. You should be able to use the public methods to get the data address or a copy of the data.
We have two problems, and I think it might be helpful to think about them separately, although you might want to add a test that has both. The first problem is interior mutability, and the second one is encapsulation.
Using transmute is necessary if you want to break encapsulation. The interior mutability could be a problem for identifying expressions that are side-effect free.
tests/expected/function-contract/interior-mutability/cell_stub.rs
Outdated
Show resolved
Hide resolved
celinval
reviewed
Jul 22, 2024
tests/expected/function-contract/interior-mutability/transmute/oncecell.rs
Outdated
Show resolved
Hide resolved
celinval
reviewed
Jul 23, 2024
tests/expected/function-contract/interior-mutability/api/cell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/cell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/unsafecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/transmute/cell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/transmute/cell_stub.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/transmute/oncecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/transmute/unsafecell.rs
Outdated
Show resolved
Hide resolved
feliperodri
approved these changes
Jul 30, 2024
tests/expected/function-contract/interior-mutability/api/unsafecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/unsafecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/cell_stub.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/cell_stub.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/api/cell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/whole-struct/oncecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/whole-struct/refcell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/whole-struct/refcell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/whole-struct/unsafecell.rs
Outdated
Show resolved
Hide resolved
tests/expected/function-contract/interior-mutability/whole-struct/unsafecell.rs
Outdated
Show resolved
Hide resolved
…uct/unsafecell.rs
…uct/unsafecell.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for interior mutability using Cell, OnceCell, UnsafeCell, and RefCell.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.