-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable "Auto label" for merge-queue actions #3409
Conversation
This will Fix merge-queue CI actions as this is a required CI action, but wasn't being run for jobs entering the queue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow will potentially invoke the benchcomp workflow, which I think may require changes as well, since it has code that depends on the event trigger. Can you please double check! Thanks
The job for invoking |
In that workflow, we have this code to extract the commits that will be compared: kani/.github/workflows/bench.yml Lines 20 to 30 in 4a92557
I think in the new case, it won't enter any of these steps, and the commits to be compared will not be defined. |
Oh, thank you for highlighting this, you are absolutely right. I will fix this, but the way I intend to fix this is by not running this performance check workflow for merge queues at all. My reasons for doing this are:
|
This will stop them from appearing in default commit messages.
Sounds good to me! |
This will Fix merge-queue CI actions as this is a required CI action, but wasn't being run for jobs entering the queue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.