Call check_proof_attribute
for contract harnesses
#3522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kani enforces that
[kani::proof]
attribute is not applied to generic functions. We do not currently enforce this restriction on contract harnesses. When the compiler searches for harnesses to verify, it only looks at monomorphized functions. Thus, currently a user can write this code:and get
"No proof harnesses (functions with #[kani::proof]) were found to verify."
In the case where a user is running many harnesses, they may not notice that Kani skipped the harness. For example, we currently have this harness in the standard library, which doesn't actually run. (PR to fix is here). After this PR merges, the code snippet above would instead error with:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.