Verify safety of to_lower and to_upper
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Oct 16, 2024
tautschnig
approved these changes
Oct 17, 2024
zhassan-aws
reviewed
Oct 17, 2024
zhassan-aws
approved these changes
Oct 28, 2024
|
@tautschnig do you want to take another look before I merge this PR? |
This is currently hitting a bug in Kani. :(
celinval
force-pushed
the
verify-0000-unicode
branch
from
a0aaf57
to
b99e4de
Compare
|
Run approval workflow... |
celinval
commented
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are safety abstractions that are auto-generated via script. Add minimum contract for now.
Note: I tried adding a slightly tighter post-condition, but Kani takes a long time to solve them. This may be an interesting test for other tools later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.