Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking issue for challenges template #27

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jaisnan
Copy link

@jaisnan jaisnan commented Jun 26, 2024

Creates an issue template for new issues that are for tracking challenges.
Right now, anyone can add a tracking issue for a challenge without the link to the challenge in the runbook.
This template will help remind them of the order of creation which would be to first, create the challenge in the runbook, then create the tracking issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner June 26, 2024 22:33
name: Tracking issue for challenge
about: Create a new tracking issue for a challenge
title: "[Tracking Challenge] "
labels: Challenge

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we update the book instructions to only create an issue once the proposal has been accepted?

Copy link
Author

@jaisnan jaisnan Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am in the middle of changing the book instructions to that right now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think that's the right approach.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem here is that the "Challenge" label would be automatically added to issues that may not be a challenge.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve that, I can add a new generic issue template that would be for issues that have nothing to do with the challenges themselves. Would that work?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to eventually have a job that runs once a new challenge has been merged, and edits the tracking issue with the link to the book entry and add the "Challenge" label. But for now, we will have to manually keep things consistent.

@jaisnan jaisnan enabled auto-merge (squash) June 26, 2024 23:12
@jaisnan jaisnan merged commit df109da into model-checking:main Jun 26, 2024
6 checks passed
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
Creates an issue template for new issues that are for tracking
challenges.
Right now, anyone can add a tracking issue for a challenge without the
link to the challenge in the runbook.
This template will help remind them of the order of creation which would
be to first, create the challenge in the runbook, then create the
tracking issue.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants