Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pr workflow to require 2 approvals on all PR's #74

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

jaisnan
Copy link

@jaisnan jaisnan commented Aug 27, 2024

Simplify pr workflow to require 2 approvals on all PR's

Call Outs

All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will need 2 approvals.

This is done to prevent sneak attacks where someone gets approval for non-std related changes, and after approval, they make changes to the std files.

Testing

Failed check after just 1 approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583003063
Successful check after 2nd approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583018556

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner August 27, 2024 17:40
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

@jaisnan
Copy link
Author

jaisnan commented Aug 27, 2024

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"?
If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.

@carolynzech
Copy link

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.

@jaisnan
Copy link
Author

jaisnan commented Aug 27, 2024

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.

Ah sorry. I think I prefer to delete, I can always refer to this PR in case I want to come back to these diffs, and I stashed these changes in my fork too. No reason to keep this branch full of redundant comments.

@tautschnig tautschnig merged commit c191318 into model-checking:main Aug 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants