Simplify pr workflow to require 2 approvals on all PR's #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify pr workflow to require 2 approvals on all PR's
Call Outs
All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will need 2 approvals.
This is done to prevent sneak attacks where someone gets approval for non-std related changes, and after approval, they make changes to the std files.
Testing
Failed check after just 1 approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583003063
Successful check after 2nd approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583018556
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.