Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent skipping due to "if" statement #80

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jaisnan
Copy link

@jaisnan jaisnan commented Sep 6, 2024

Prevent pr approval from getting skipped when there is a non-approval review submitted on the PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner September 6, 2024 21:09
carolynzech
carolynzech previously approved these changes Sep 6, 2024
@carolynzech carolynzech dismissed their stale review September 6, 2024 21:13

testing if this PR works with one approval and one comment

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

@jaisnan jaisnan enabled auto-merge (squash) September 6, 2024 21:16
@jaisnan jaisnan merged commit e29fb31 into model-checking:main Sep 6, 2024
8 of 10 checks passed
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
Prevent pr approval from getting skipped when there is a non-approval
review submitted on the PR.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants