-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(enhanced): resolve webpack semver parser #2587
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # packages/nextjs-mf/src/internal.ts
ensure share via expose is always selected
fix: add share logic just for next
webpack semver parser is light but has a few bugs we will fix here
backporting async boundary design from vmok and modernJS
Flag to allow webpack to startup without needing a async boundary or dynamic import
backporting async bounday that uses runtime requirements and startup encapsulation with reexporting
feat(enhanced): new async boundary plugin design
# Conflicts: # package.json # packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts # packages/enhanced/src/lib/container/ModuleFederationPlugin.ts # packages/nextjs-mf/CHANGELOG.md # packages/nextjs-mf/package.json # packages/nextjs-mf/src/internal.ts # packages/nextjs-mf/src/plugins/NextFederationPlugin/index.ts # packages/nextjs-mf/src/plugins/container/InvertedContainerPlugin.ts # packages/nextjs-mf/src/plugins/container/InvertedContainerRuntimeModule.ts
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7c09b93
to
87224a0
Compare
* @param {string} str version string | ||
* @returns {(string|number|undefined|[])[]} parsed version | ||
*/ | ||
const parseVersion = (str) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file might replace the semver in the runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i hope so, much lighter than the package
|
||
'use strict'; | ||
|
||
import type RuntimeTemplate from 'webpack/lib/RuntimeTemplate'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace the semver logic in the runtime with this,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation. Let me check
Description
Resolve Semver Parser issues when ~ is used
Related Issue
Types of changes
Checklist