Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enhanced): resolve webpack semver parser #2587

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

Description

Resolve Semver Parser issues when ~ is used

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

ScriptedAlchemy and others added 25 commits October 23, 2023 12:43
# Conflicts:
#	packages/nextjs-mf/src/internal.ts
ensure share via expose is always selected
webpack semver parser is light but has a few bugs we will fix here
backporting async boundary design from vmok and modernJS
Flag to allow webpack to startup without needing a async boundary or dynamic import
backporting async bounday that uses runtime requirements and startup encapsulation with reexporting
feat(enhanced): new async boundary plugin design
# Conflicts:
#	package.json
#	packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts
#	packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
#	packages/nextjs-mf/CHANGELOG.md
#	packages/nextjs-mf/package.json
#	packages/nextjs-mf/src/internal.ts
#	packages/nextjs-mf/src/plugins/NextFederationPlugin/index.ts
#	packages/nextjs-mf/src/plugins/container/InvertedContainerPlugin.ts
#	packages/nextjs-mf/src/plugins/container/InvertedContainerRuntimeModule.ts
Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: 9249772

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 9249772
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66864ae744dde400086e015c
😎 Deploy Preview https://deploy-preview-2587--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* @param {string} str version string
* @returns {(string|number|undefined|[])[]} parsed version
*/
const parseVersion = (str) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might replace the semver in the runtime

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i hope so, much lighter than the package


'use strict';

import type RuntimeTemplate from 'webpack/lib/RuntimeTemplate';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace the semver logic in the runtime with this,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. Let me check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants