Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: async chunk startup #2814

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

ScriptedAlchemy
Copy link
Member

Description

Testing internal modifications to webpack for async entry startup before implementing in rust for rspack.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 2b55aa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 2b55aa1
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66b5486de8d21800096c0f80
😎 Deploy Preview https://deploy-preview-2814--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RussellCanfield
Copy link
Collaborator

@squadronai review

Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This pull request introduces modifications to the webpack configuration for async entry startup, which is being tested before implementing in Rust for rspack. The key changes are in the ModuleFederationPlugin.ts file, where the code imports and initializes schema validation and a StartupChunkDependenciesPlugin. The StartupChunkDependenciesPlugin is then applied to the compiler with asyncChunkLoading set to true, and a DtsPlugin is conditionally applied based on the options. These changes are part of the ongoing effort to improve the performance and functionality of the module federation feature in the project.

File Summaries
File Summary
packages/enhanced/src/lib/container/ModuleFederationPlugin.ts The code imports and initializes schema validation and a StartupChunkDependenciesPlugin. It then applies the StartupChunkDependenciesPlugin to the compiler with asyncChunkLoading set to true, and conditionally applies a DtsPlugin based on options.

Commits reviewed:

be5f11a4ae440a56a8b53d2ea5db76fc0d4886fb...329e7c8e2d6a0d7cde8c6e1f8704f07d77a6c3c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants