Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests based on the examples #111

Closed
gioboa opened this issue Sep 25, 2024 · 5 comments · Fixed by #120
Closed

feat: add e2e tests based on the examples #111

gioboa opened this issue Sep 25, 2024 · 5 comments · Fixed by #120
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gioboa
Copy link
Collaborator

gioboa commented Sep 25, 2024

The idea is to have e2e tests to verify that the package is working as expected.
We can use the examples for that.

@gioboa gioboa added good first issue Good for newcomers help wanted Extra attention is needed COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels Sep 25, 2024
@bidodev
Copy link
Contributor

bidodev commented Sep 26, 2024

Hey @gioboa, first of all, thanks for this plugin and all the hard work! Currently, we're using another one, but we are already testing this one for production.

I saw your request and would like to contribute. I plan to test it using Playwright, but I have a few questions before proceeding.

Do you have the examples deployed somewhere? If so, I can set up Playwright in the repository and create some e2e tests for each example.

If they're not deployed, could we maybe use GitHub Pages for that? Or do you have something else in mind?

Once I get clearance, I'll be ready to start working on it.

@gioboa
Copy link
Collaborator Author

gioboa commented Sep 26, 2024

Hi @bidodev thanks for your help.
We don't have any deployment yet, in this PR #57 we suggested GH pages.
I think we can run the e2e with a GH action so there is no need of deployment.
I'm looking forward to hearing your thoughts.

@bidodev
Copy link
Contributor

bidodev commented Sep 27, 2024

Hey @gioboa that also works, I will start working on an MR for that.

@bidodev
Copy link
Contributor

bidodev commented Sep 29, 2024

@gioboa I've set up a basic environment and written some initial tests, here: #120. Please let me know if I'm on the right track, so I can add more tests.

@gioboa
Copy link
Collaborator Author

gioboa commented Sep 29, 2024

That's great 🚀 @bidodev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants