-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add e2e tests for multi-example app #120
Conversation
@bidodev that's perfect 👍 what's the benefit to upload the artifacts at the end of the GH action? |
@gioboa This can be useful for debugging in case of test failures. I adjusted it to upload only when a test fails, and retain only for 3 days, does it work for you? |
8f315f8
to
3c13d51
Compare
Can we download an use the artifact locally? If yes, this could be amazing because we can have a preview package after each commit. We can test things easily by linking it |
@gioboa I'm not sure if I understood correctly. When a test fails, Playwright creates a trace, one can download them and then replay the trace either offline or online using tools such https://trace.playwright.dev/, doing so, one can see where it failed. More info: https://playwright.dev/docs/trace-viewer. Your idea is to check if the integration was successful after every commit, e.g., by running all the e2e tests locally in the pre-commit phase? |
I see. The PR is perfect, the idea is to run e2e tests after each commit to guarantee the solidity of the codebase. |
c4a8cdf
to
4cf69db
Compare
Hey @gioboa II’ve added the option in the pre-hook commit to run all the tests against the multi-example. For the other examples, I would run them on every pull request and on the main branch. However, I have a couple of questions. When I ran pnpm dev-nv, what is the expected result? Does this example work? I only see this: And also for the rust-vite example, I keep getting this error: https://github.com/bidodev/vite/actions/runs/11113332073/job/30877425804 |
Based on this issue #73 I think the nuxt example is not working fine. |
@bidodev we need e2e tests to prevent regressions so I completed this PR. |
Hey @gioboa thanks for finalizing the MR, I got a flu / covid and couldn't finish it 🥲 |
Get well soon 💪 |
Closes: #111