Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @module-federation/runtime version #182

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

JamesMHenderson
Copy link
Contributor

fixes #158

@gioboa
Copy link
Collaborator

gioboa commented Nov 9, 2024

Thanks @JamesMHenderson
Some tests are failing 🤔
You change is pretty straightforward though

@JamesMHenderson
Copy link
Contributor Author

JamesMHenderson commented Nov 11, 2024

@gioboa I've redone the package update, ran the unit test locally and they all now pass, but I am having issues running the multi-example script think this is due to me running on a windows environment.

After change the scripts to be compatible for Windows I got the multi-example working and all playwright tests pass in my local environment

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JamesMHenderson
It looks fine to me

@gioboa gioboa merged commit 1660524 into module-federation:main Nov 11, 2024
4 checks passed
@JamesMHenderson
Copy link
Contributor Author

@gioboa is it possible to get a version of the package release including this change?

@gioboa
Copy link
Collaborator

gioboa commented Nov 15, 2024

@gioboa is it possible to get a version of the package release including this change?

Yup, I'll cut a release right now. I was waiting to include other fixes but a new version sounds reasonable to me.

---- UPDATE ----

Here is the new release 1.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load remote unless CSP "unsafe-eval" CSP header is set
2 participants