feat: structuring event and command handlers separation #17
Conversation
ruirochawork
commented
May 17, 2024
ruirochawork
commented
- Added Structuring event and command handlers separation
- Increased unit test coverage
…ation # Conflicts: # package-lock.json # package.json # packages/quoting-api-svc/package.json # packages/quoting-svc/src/service.ts
ruirochawork
requested review from
pedrosousabarreto,
koekiebox,
tw-aungthawaye,
myo-min-htet,
ZweHMyat,
SithuKyaw-Thitsaworks,
elnyry-sam-k and
bushjames
as code owners
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const mockedAuthorizationClient: IAuthorizationClient = new MemoryAuthorizationClient(logger); | ||
|
|
||
| const accessToken = "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IkR1RVNzRFdmb2JjRURQODR4c2hjU2sxUFJsMnMwMUN0RW9ibkNoRUVFT2cifQ.eyJ0eXAiOiJCZWFyZXIiLCJhenAiOiJzZWN1cml0eS1iYy11aSIsInJvbGVzIjpbImh1Yl9vcGVyYXRvciJdLCJpYXQiOjE2OTgwMjEwNTksImV4cCI6MTY5ODYyNTg1OSwiYXVkIjoibW9qYWxvb3Audm5leHQuZGV2LmRlZmF1bHRfYXVkaWVuY2UiLCJpc3MiOiJtb2phbG9vcC52bmV4dC5kZXYuZGVmYXVsdF9pc3N1ZXIiLCJzdWIiOiJ1c2VyOjp1c2VyIiwianRpIjoiYzFkNjdkMTEtYzExNS00MTU0LTlmZDEtZThlNDI5M2E3YjFkIn0.QK6QVblcaKldvdbCH6sWSa7kqrOjJ1urWcp6dyMWo0Ln7Faq29bPE4t4Mcd-WQVhO3a1sE-YhBrcpUNI0YCbbS5rRdI1SRqnCMWv3g9vyDKEnIFFu_6LM7K1Ct_JGpT4fP4KMVnT03mMeobIESbVu8Ep1zSfLWv2TAB4EzZUlh-HeJMDaUj8ESM91PdXmCHieM1br3JLwuy2WSxMJSbjYrH1G68TW38U4CPBTyhRwiwlB8Ro5MTjHqdH8EQC7A_E4iwwe-GkuoP63qOSPA0ZZ0O7Ry-dRhyips_S3cSjGWAgwXDyylh5Q4OjAtTpD1di1bm2uj1lXXkFC3cDQiV94Q"; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
| // Act | ||
| const response = await request(server) | ||
| .get(`/quotes/${quoteId}`) | ||
| .set(`Authorization`, `invalidbearertoken`); |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
| const LOG_LEVEL: LogLevel = (process.env["LOG_LEVEL"] as LogLevel) || LogLevel.DEBUG; | ||
|
|
||
| const KAFKA_URL = process.env["KAFKA_URL"] || "localhost:9092"; | ||
| const MONGO_URL = process.env["MONGO_URL"] || "mongodb://root:mongoDbPas42@localhost:27017/"; |
There was a problem hiding this comment.
Comment from sonarcloud scan: "Make sure this MongoDB database password gets changed and removed from the code."
Please address this security issue and lets make the best use of the analysis from the available tooling. Analysis on this PR here: https://sonarcloud.io/summary/new_code?id=mojaloop_quoting-bc&pullRequest=17
| const LOG_LEVEL: LogLevel = process.env["LOG_LEVEL"] as LogLevel || LogLevel.DEBUG; | ||
|
|
||
| const KAFKA_URL = process.env["KAFKA_URL"] || "localhost:9092"; | ||
| const MONGO_URL = process.env["MONGO_URL"] || "mongodb://root:mongoDbPas42@localhost:27017/"; |
There was a problem hiding this comment.
Issue reported by sonarcloud with comment: "Make sure this MongoDB database password gets changed and removed from the code."
Full analysis on this PR is here: https://sonarcloud.io/summary/new_code?id=mojaloop_quoting-bc&pullRequest=17
|
hi @ruirochawork, thanks for the PR. Couple of comments:
|
