Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See commit history #41

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

See commit history #41

wants to merge 46 commits into from

Conversation

mmterpstra
Copy link

No description provided.

duartemolha and others added 30 commits October 10, 2017 12:00
…nce based on input BAM files or Counts and a folder of preprocessed controls; Added support to detailing intervals within targets by using the score filed on the Bed file; LOTS AND LOTS OF code cleanup and removal of global variables that made the code difficult to understand and un on a pipeline mode; converted from using hard coded temporary files and used FILE::Temp perl module instead that deals automaticaly with temp file cleanup
…y on the set without requiring changing paths assuming they are run from within repo
…dded output of bedfiles with GFFtags metadata for IGV output
* Update .travis.yml

* Update .travis.yml

* Update Makefile.PL

* Update .travis.yml

* Update Makefile.PL

* Update Makefile.PL

* Update CoNVaDING.t
@mmterpstra
Copy link
Author

Good luck on the validation!

Copy link

@duartemolha duartemolha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/molgenis/CoNVaDING_reload

Is a wrong link ... you pulled changes from my fork... I have no issue with keeping references to the original project ... but the CoNVaDING_reload is here:
https://github.com/duartemolha/CoNVaDING_reload

:)

@mmterpstra
Copy link
Author

I was hoping for them to inspect the project but due to the large amount of changes they postponed it.

One if the things missing in my repo is runnning a test on the data using the test data in the repo can you provide me the code for running it on the test data. This would be a nice addition. An additional thing to do is to add an error on reading 0 entry bed file cause the program reopens and reads the bedfile multiple times causing vague errors when you stream the bedfile into it.

lib/CoNVaDING.pm Outdated

=head1 SEE ALSO

https://github.com/molgenis/CoNVaDING_reload
Copy link

@duartemolha duartemolha Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://github.com/molgenis/CoNVaDING_reload
https://github.com/molgenis/CoNVaDING

lib/CoNVaDING.pm Outdated

GNU LESSER GENERAL PUBLIC LICENSE

original version at https://github.com/molgenis/CoNVaDING_reload

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
original version at https://github.com/molgenis/CoNVaDING_reload
original version at https://github.com/molgenis/CoNVaDING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants