Skip to content

Commit

Permalink
Merge pull request #31 from molssi-seamm/dev
Browse files Browse the repository at this point in the history
Fixed bugs running xTB due to format erros and missing parameters.
  • Loading branch information
seamm committed Feb 18, 2023
2 parents 76c2f9d + fa7015b commit dd4fa72
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
3 changes: 3 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
History
=======

2023.2.17.2 -- Fixed bug with xTB parameters
* xTB runs have a blank line in results.tag which caused a crash.

2023.2.17.1 -- Fixed Linux bug with thread limit

2023.2.17 -- Limiting number of threads
Expand Down
2 changes: 1 addition & 1 deletion dftbplus_step/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ def parse_results(self, lines):
try:
while True:
lineno, line = next(line_iter)
if line[0] == "#":
if len(line) == 0 or line[0] == "#":
continue
if ":" not in line:
raise RuntimeError(
Expand Down
12 changes: 9 additions & 3 deletions dftbplus_step/energy.py
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,14 @@ def make_plots(self, data):
dataset = self.parent._dataset
subset = self.parent._subset
if subset is not None:
subset_data = subset["element data"]
element_data = dataset["element data"]
if "element data" in subset:
subset_data = subset["element data"]
else:
subset_data = {}
if "element data" in dataset:
element_data = dataset["element data"]
else:
element_data = {}

basis = input_data["Basis"]
missing = []
Expand All @@ -796,7 +802,7 @@ def make_plots(self, data):
and "wfc" in subset_data[element]
):
basis[element] = subset_data[element]["wfc"]
elif "wfc" in element_data[element]:
elif element in element_data and "wfc" in element_data[element]:
basis[element] = element_data[element]["wfc"]
else:
missing.append(element)
Expand Down

0 comments on commit dd4fa72

Please sign in to comment.