Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/public checkbox #148

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

janash
Copy link
Member

@janash janash commented May 21, 2024

This PR fixes a bug where a project could not be made private again after selecting public.

@janash janash closed this May 21, 2024
@janash janash reopened this May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@2b3774b). Learn more about missing BASE report.

Files Patch % Lines
seamm_dashboard/routes/projects/views.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage        ?   46.62%           
=======================================
  Files           ?       35           
  Lines           ?     2074           
  Branches        ?        0           
=======================================
  Hits            ?      967           
  Misses          ?     1107           
  Partials        ?        0           
Flag Coverage Δ
unittests 46.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulsaxe paulsaxe self-requested a review May 22, 2024 16:30
Copy link
Contributor

@paulsaxe paulsaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And simple 😃

@paulsaxe paulsaxe merged commit 1bd8f93 into molssi-seamm:main May 22, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants