initialize cpl_scalar field in nuopc cap #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialize cpl_scalar field when created
…n-20240531 update to main 20240729 commit (gfdl-to-main-2024-05-31)
…n-20240824 update to main 20240824
jiandewang
requested review from
alperaltuntas,
marshallward,
abozec,
kshedstrom and
mathomp4
mathomp4
approved these changes
Sep 9, 2024
|
@kshedstrom I guess this PR bypassed your radar, can you review it ? |
kshedstrom
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this mini PR add the initialization of cpl_scalar filed in nuopc cap.
In UFS, it was reported that "Non-CSG components do not use or set the scalar index for NTile. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). " See detail at UFS issue (ufs-community/ufs-weather-model#2369 and ufs-community/ufs-weather-model#2338).
non-CSG= non Cubic Spherical Grid which refers to ocean, ice and wave models in UFS
Thansk for @alperaltuntas for pre-checking of the code change.