Skip to content

Commit

Permalink
Merge pull request #454 from monarch-initiative/#449-update-dependencies
Browse files Browse the repository at this point in the history
Update dependencies
  • Loading branch information
ielis authored Nov 20, 2023
2 parents 9717e7f + 52a5291 commit 2a5291d
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 17 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.monarchinitiative.phenol.annotations.formats.mpo;


import com.google.common.collect.ImmutableSet;
import org.junit.jupiter.api.Test;
import org.monarchinitiative.phenol.ontology.data.TermId;

Expand All @@ -15,7 +14,7 @@ public class MpAnnotationTest {
@Test
public void testAnnotationTypeString() {
TermId mpId = TermId.of("MP:123");
Set<String> pmids = ImmutableSet.of();
Set<String> pmids = Set.of();
MpAnnotation.Builder builder = new MpAnnotation.Builder(mpId,pmids).sexSpecific(MpSex.FEMALE);
MpAnnotation annot = builder.build();
String expected = "MP:123FEMALE_SPECIFIC_ABNORMAL";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.monarchinitiative.phenol.annotations.hpo;

import com.google.common.collect.ImmutableSet;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -84,14 +83,14 @@ void testNumberOfAnnotationsPostmerge() {
}
assertNotNull(anophthalmiaEntry);
assertEquals(expectedFrequency,anophthalmiaEntry.getFrequencyModifier());
Set<String> expectedBiocuration= ImmutableSet.of("HP:probinson[2018-05-28]","HP:probinson[2019-05-28]");
Set<String> expectedBiocuration= Set.of("HP:probinson[2018-05-28]","HP:probinson[2019-05-28]");
String actualBiocuration=anophthalmiaEntry.getBiocuration();
String[] bioc=actualBiocuration.split(";");
for (String biocurationItem : bioc) {
assertTrue(expectedBiocuration.contains(biocurationItem));
}

Set<String> expectedPublication=ImmutableSet.of("PMID:3214","PMID:1234");
Set<String> expectedPublication=Set.of("PMID:3214","PMID:1234");
String actualPub=anophthalmiaEntry.getPublication();
String []pubs=actualPub.split(";");
for (String pub:pubs) {
Expand Down
1 change: 0 additions & 1 deletion phenol-io/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<groupId>org.geneontology.obographs</groupId>
<artifactId>obographs-core</artifactId>
</dependency>
<!-- We can drop the dependency after obographs-core updates the vulnerable snakeyaml 1.33 to >=2.0. -->
<dependency>
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
Expand Down
1 change: 0 additions & 1 deletion phenol-io/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@
requires obographs.core;
requires org.yaml.snakeyaml;
requires com.fasterxml.jackson.databind;
requires com.fasterxml.jackson.datatype.guava;
requires org.slf4j;
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.monarchinitiative.phenol.io.obographs;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.datatype.guava.GuavaModule;
import org.geneontology.obographs.core.model.GraphDocument;

import java.io.IOException;
Expand All @@ -18,10 +17,6 @@ public class OboGraphDocumentLoader {

private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

static {
OBJECT_MAPPER.registerModule(new GuavaModule());
}

private OboGraphDocumentLoader() {
}

Expand Down
10 changes: 5 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>

<obographs.version>0.3.0</obographs.version>
<obographs.version>0.3.1</obographs.version>
<jackson.version>2.14.3</jackson.version>
<guava.version>30.1-jre</guava.version>
<snakeyaml.version>2.0</snakeyaml.version>
<guava.version>[32.0.1-jre,)</guava.version>
<snakeyaml.version>[2.0,3.0)</snakeyaml.version>
<jgrapht.version>1.5.2</jgrapht.version>
<slf4j.version>2.0.7</slf4j.version>
<slf4j.version>[2.0,3.0)</slf4j.version>
<commons-codec.version>1.15</commons-codec.version>
<commons-csv.version>1.10.0</commons-csv.version>
<h2.version>1.4.200</h2.version>
<h2.version>[2.2.220,3.0)</h2.version>
<picocli.version>4.6.3</picocli.version>

<hamcrest.version>2.2</hamcrest.version>
Expand Down

0 comments on commit 2a5291d

Please sign in to comment.