Skip to content

Commit

Permalink
🐛 gcp compute instances should be labelled as platform instance not i…
Browse files Browse the repository at this point in the history
…mage (#1591)

also, i didn't touch the logic for this part right now, but why are we
entirely skipping windows instances, like not discovering them at all?
@preslavgerchev @imilchev does one of you know?
```
		if disksContainWindows(i.Disks) {
			log.Debug().Msgf("skipping windows instance %s", i.Name)
			continue
		}
```
  • Loading branch information
vjeffrey authored Aug 28, 2023
1 parent fac411f commit 1cfa9d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion motor/discovery/gcp/mql_asset_objects.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func computeInstances(m *MqlDiscovery, project string, tc *providers.Config, sfn
name: i.Name,
id: i.Id,
service: "compute",
objectType: "image",
objectType: "instance",
},
}, tc)
a.State = mapInstanceStatus(i.Status)
Expand Down

0 comments on commit 1cfa9d8

Please sign in to comment.