Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix fetching of fields for role definitions #4571

Merged
merged 1 commit into from
Aug 19, 2024
Merged

🐛 fix fetching of fields for role definitions #4571

merged 1 commit into from
Aug 19, 2024

Conversation

chris-rock
Copy link
Member

We need to fetch the field isBuiltIn when we fetch roles. This allows us to filter roles quickly:

cnquery> microsoft.roles.where(isBuiltIn == false)
microsoft.roles.where: []

@github-actions GitHub Actions
Copy link
Contributor

Test Results

3 097 tests  ±0   3 096 ✅ ±0   1m 29s ⏱️ +10s
  370 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 63d5dac. ± Comparison against base commit b772da8.

@vjeffrey vjeffrey merged commit 9276f04 into main Aug 19, 2024
15 checks passed
@vjeffrey vjeffrey deleted the chris-rock/fix-role-definition branch August 19, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-rock @preslavgerchev @vjeffrey