🧹 improve the sagemaker notebook instance & iam mfadevice resource #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
changed the title
vjeffrey
force-pushed
the
vj/improvesagemaker
branch
from
8f9ed74
to
75075e3
Compare
providers/aws/resources/aws_iam.go
Outdated
| } | ||
| return awsIamUser.(*mqlAwsIamUser), nil | ||
| } | ||
| a.User.State = plugin.StateIsNull |
There was a problem hiding this comment.
do we need to set this too in case we hit the cache?
vjeffrey
force-pushed
the
vj/improvesagemaker
branch
from
75075e3
to
bee49c1
Compare
preslavgerchev
approved these changes
Aug 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.