🧹 improve aws s3 buckets resource #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Aug 30, 2024
providers/aws/resources/aws.lr
Outdated
| @@ -1717,7 +1717,7 @@ aws.s3 @defaults("buckets") { | |||
| } | |||
|
|
|||
| // Amazon S3 bucket | |||
| private aws.s3.bucket @defaults("name location public") { | |||
There was a problem hiding this comment.
Is there to do this without losing the location?
There was a problem hiding this comment.
unfortunately i dont think so..
:/
if aws returned the region on the list response this wouldnt be a problem, the extra api call is annoying
There was a problem hiding this comment.
Could we derive the location from the arn?
There was a problem hiding this comment.
unfortunately it's not in the arn for s3. i could also remove the location change stuff and just leave the rest of the optimization in
There was a problem hiding this comment.
chatted with tim, im gonna bring back the location by default part
chris-rock
approved these changes
Sep 14, 2024
providers/aws/resources/aws.lr
Outdated
| @@ -1717,7 +1717,7 @@ aws.s3 @defaults("buckets") { | |||
| } | |||
|
|
|||
| // Amazon S3 bucket | |||
| private aws.s3.bucket @defaults("name location public") { | |||
There was a problem hiding this comment.
Could we derive the location from the arn?
vjeffrey
force-pushed
the
vj/improves3
branch
from
f24d2ed
to
556f14a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i also wanted to switch to using HeadBucket to get the location but the api apparently requires that api to be called for the correct region to get a response, so it ends up being more api calls to do so