Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use go 1.23 #4622

Merged
merged 1 commit into from
Sep 2, 2024
Merged

✨ use go 1.23 #4622

merged 1 commit into from
Sep 2, 2024

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Sep 2, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Test Results

3 097 tests  ±0   3 096 ✅ ±0   1m 36s ⏱️ -2s
  370 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 6aad441. ± Comparison against base commit 9ea78c9.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
@slntopp
Copy link
Member

slntopp commented Sep 2, 2024

Why are we updating version in go.mod?

That would make dependant software and packages with older go versions incompatible

@imilchev
Copy link
Member Author

imilchev commented Sep 2, 2024

Why are we updating version in go.mod?

That would make dependant software and packages with older go versions incompatible

that's a good point but we always did it with previous updates as well. I think this is something we can discuss internally for future update but I don't want to block the current upgrade.

@imilchev imilchev merged commit 2638643 into main Sep 2, 2024
14 checks passed
@imilchev imilchev deleted the ivan/go-1.23 branch September 2, 2024 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants