🧹 Improving the keyVault resources to cover automatic key rotation policy

[HRouhani]

• Ensure Automatic Key Rotation is Enabled Within Azure Key Vault for the Supported Services

[github-actions]

Test Results

3 098 tests  ±0   3 097 ✅ ±0   1m 20s ⏱️ ±0s
  370 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 1ae7e0d. ± Comparison against base commit 342ea94.

♻️ This comment has been updated with latest results.

[vjeffrey]

could we make this an optional field and only call the api if needed? (add the parens here and move the call to a function)

[misterpantz]

If you do keep it like it is, please change the description to:

Suggested change

	// Auto-rotation enabled status
	// Whether auto-rotation is enabled

Thanks!

[HRouhani]

@vjeffrey I did as you requested, however I still could not solve the uniqueness of the keys:

[vjeffrey]

oh, is there maybe an id function missing? i haven't re-checked the code, i'll look when i get online in a while, but usually that's an id thing

[HRouhani]

Thanks VJ, I already added id function as here:

func (a *mqlAzureSubscriptionKeyVaultServiceKeyAutorotation) keyName() (string, error) {
	id := a.Kid.Data
	kvid, err := parseKeyVaultId(id)
	if err != nil {
		return "", err
	}

	return kvid.Name, nil
}

[preslavgerchev]

the function should be named id() for this to work. alternatively you can just pass in the id directly in the args as __id

[HRouhani]

@preslavgerchev awesome, Thanks. It works now. Appreciate you help.

[vjeffrey]

is the name guaranteed unique? if not, could just use the id itself here

[HRouhani]

yes, it is always unique!

[preslavgerchev]

shouldn't this be under the key resource and not the vault resource?

[HRouhani]

I am happy you raised that, it was our plan, but in this way we get following error:

# go.mondoo.com/cnquery/v11/providers/azure/resources
resources/azure.lr.go:14246:12: c.autorotation undefined (type *mqlAzureSubscriptionKeyVaultServiceKey has no field or method autorotation, but does have field Autorotation)
make[1]: *** [Makefile:339: providers/build/azure] Error 1

if we do:

// Azure Key Vault key
private azure.subscription.keyVaultService.key @defaults("kid keyName") {
  // Key ID
  kid string
  // Key tags
  tags map[string]string
  // Whether the key is managed
  managed bool
  // Whether the key is enabled
  enabled bool
  // Date the key begins to be usable
  notBefore time
  // Date the key expires
  expires time
  // Key creation time
  created time
  // Key last update time
  updated time
  // Key recovery level
  recoveryLevel string
  // Key name
  keyName() string
  // Key version
  version() string
  // List of key versions
  versions() []azure.subscription.keyVaultService.key
  // Auto-rotation enabled status for all keys
  autorotation() []azure.subscription.keyVaultService.key.autorotation
}
``