🐛 Handle Chassis returned as slice #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slntopp
commented
Sep 3, 2024
| @@ -14,7 +14,7 @@ import ( | |||
| const smbiosWindowsScript = ` | |||
| $bios = Get-WmiObject -class Win32_Bios | |||
| $baseboard = Get-WmiObject Win32_BaseBoard | |||
| $chassis = Get-WmiObject Win32_SystemEnclosure | |||
| $chassis = @(Get-WmiObject Win32_SystemEnclosure) | |||
There was a problem hiding this comment.
Note on PowerShell syntax:
- The
@()syntax is used to (force) create an array in PowerShell.
|
Can be tested with this script: (@(Get-Process -IncludeUserName | Select-Object Name, Id, Path) | ConvertTo-Json) -eq (Get-Process -IncludeUserName | Select-Object Name, Id, Path | ConvertTo-Json)
|
|
Also worth noting, as documentation suggests, all |
| Model: toString(winBios.Chassis.Model), | ||
| Version: winBios.Chassis.Version, | ||
| SerialNumber: winBios.Chassis.SerialNumber, | ||
| ChassisInfo: ChassisInfo{ // TODO: Might want to make this a slice |
There was a problem hiding this comment.
can this be nil? if winBios.Chassis is 0, we may as well jst set this to nil. we're currently filling in an empty struct that holds no value. if this cannot be nil, then thats ok
There was a problem hiding this comment.
It can't technically be, since it's not a pointer
Changing the type at this point would be even more breaking than making it slice, which would've been better solution imo
preslavgerchev
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.