⭐️ Adding conditional Access - Named location part #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HRouhani
commented
Sep 5, 2024
•
HRouhani
commented
- Ensure Trusted Locations Are Defined
misterpantz
reviewed
Sep 5, 2024
HRouhani
force-pushed
the
hossein/ms365-Entra-ID-Trusted-Locations
branch
3 times, most recently
from
53dad50
to
f0a4ad1
Compare
jaym
reviewed
Sep 18, 2024
| } | ||
|
|
||
| if len(locationDetails) == 0 { | ||
| log.Println("No named locations are defined.") |
There was a problem hiding this comment.
i think we use zerolog for logging in this project. Also, if this is a normal condition it probably doesn't need to be logged
There was a problem hiding this comment.
Done, Thanks for the feedback
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
HRouhani
force-pushed
the
hossein/ms365-Entra-ID-Trusted-Locations
branch
from
eca06ae
to
0df4126
Compare
jaym
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.