Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Remove discovery filters parameter from Discover #4691

Merged
merged 11 commits into from
Sep 26, 2024
Merged

🧹 Remove discovery filters parameter from Discover #4691

merged 11 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Remove discovery filters parameter from Discover and solely rely on f… 

    …ilters from AwsConnection.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9247bf5 View commit details
    Browse the repository at this point in the history

  2. Added license header to new files. 

    Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f983f66 View commit details
    Browse the repository at this point in the history

  3. Added ECS discovery filters parsing from inventory config. 

    Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    78a0956 View commit details
    Browse the repository at this point in the history

  4. Added 'ec2' prefix in front of instance id ec2 filter tag name. 

    Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dbd4d86 View commit details
    Browse the repository at this point in the history

  5. Extract function to determine applicable regions from which instances… 

    … should be queried.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4396bbb View commit details
    Browse the repository at this point in the history

  6. Add unit test to the function that determines which regions are appli… 

    …cable.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f530e7b View commit details
    Browse the repository at this point in the history

  7. Simplified function to determine applicable regions. 

    Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0dab40b View commit details
    Browse the repository at this point in the history

  8. Use comma-separated values instead of individual keys in the filters … 

    …map and implement parsing of CLI flags to opts matching them to known filter prefixes.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d4a059e View commit details
    Browse the repository at this point in the history

  9. Fix unit test for parsing options to discovery filters. 

    Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    19042d9 View commit details
    Browse the repository at this point in the history

  10. Improve cases for each tag to equals instead of HasPrefix where we no… 

    … longer embed the value into the key.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    adbfee4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix bug where an instance with a specific id gets retrieved from a gi… 

    …ven region but propagate an error when we attempt to find it from another region it is not in.

Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
    @VasilSirakov
    VasilSirakov committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8a9f783 View commit details
    Browse the repository at this point in the history