Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 improve cvss version detection #4692

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Sep 25, 2024

fixes #4690

Improves the CVSS version detection for vector strings without a prefix score like CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:L/I:L/A:N. Going forward we also need to add the calculation of the score itself.

@chris-rock chris-rock force-pushed the chris-rock/cvss-version-detection branch from d155547 to 7ade5f2 Compare September 25, 2024 10:35
Copy link
Contributor

Test Results

3 100 tests  +1   3 099 ✅ +1   1m 29s ⏱️ +3s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 7ade5f2. ± Comparison against base commit 77779d0.

@czunker
Copy link
Contributor

czunker commented Sep 25, 2024

Thanks @chris-rock

@czunker czunker merged commit fc20edb into main Sep 25, 2024
15 checks passed
@czunker czunker deleted the chris-rock/cvss-version-detection branch September 25, 2024 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVSS v3.1 vector is identified as v2
2 participants