🧹 remove share report flag (#1043)

* 🧹 remove share report flag

* 🧹 remove unused proto files

Makefile

@@ -66,7 +66,7 @@ prep/tools:
 
 # 🌙 cnspec #
 
-cnspec/generate: clean/proto cli/generate policy/generate upstream/generate
+cnspec/generate: clean/proto cli/generate policy/generate
 
 .PHONY: cli
 cli/generate:
@@ -76,12 +76,8 @@ cli/generate:
 policy/generate:
  go generate ./policy
  go generate ./policy/scan
- go generate ./policy/upstream
  go generate ./internal/bundle/yacit
 
-upstream/generate:
- go generate ./upstream
-
 # 🏗 Binary #
 
 .PHONY: cnspec/build

apps/cnspec/cmd/config/config.go

@@ -27,7 +27,4 @@ type CliConfig struct {
  // Asset Category
  Category string `json:"category,omitempty" mapstructure:"category"`
  AutoDetectCICDCategory bool `json:"detect-cicd,omitempty" mapstructure:"detect-cicd"`
-
- // Configure report sharing
- ShareReport *bool `json:"share_report,omitempty" mapstructure:"share_report"`
 }

apps/cnspec/cmd/scan.go

@@ -27,7 +27,6 @@ import (
  "go.mondoo.com/cnspec/v10/cli/reporter"
  "go.mondoo.com/cnspec/v10/policy"
  "go.mondoo.com/cnspec/v10/policy/scan"
- policy_upstream "go.mondoo.com/cnspec/v10/policy/upstream"
 )
 
 const (
@@ -63,7 +62,6 @@ func init() {
  scanCmd.Flags().String("category", "inventory", "Set the category for the assets to 'inventory|cicd'.")
  scanCmd.Flags().MarkHidden("category")
  scanCmd.Flags().Int("score-threshold", 0, "If any score falls below the threshold, exit 1.")
- scanCmd.Flags().Bool("share", false, "create a web-based private reports when cnspec is unauthenticated. Defaults to false.")
  scanCmd.Flags().String("output-target", "", "Set output target to which the asset report will be sent. Currently only supports AWS SQS topic URLs and local files")
 }
 
@@ -101,7 +99,6 @@ To manually configure a policy, use this:
  viper.BindPFlag("asset-name", cmd.Flags().Lookup("asset-name"))
  viper.BindPFlag("category", cmd.Flags().Lookup("category"))
  viper.BindPFlag("score-threshold", cmd.Flags().Lookup("score-threshold"))
- viper.BindPFlag("share", cmd.Flags().Lookup("share"))
 
  // for all assets
  viper.BindPFlag("incognito", cmd.Flags().Lookup("incognito"))
@@ -157,26 +154,6 @@ var scanCmdRun = func(cmd *cobra.Command, runtime *providers.Runtime, cliRes *pl
  log.Fatal().Err(err).Msg("failed to write report to output target")
  }
 
- var shareReport bool
- if viper.IsSet("share") {
- shareReportFlag := viper.GetBool("share")
- shareReport = shareReportFlag
- }
-
- // if report sharing was requested, share the report and print the URL
- if conf.IsIncognito && shareReport {
- proxy, err := config.GetAPIProxy()
- if err != nil {
- log.Error().Err(err).Msg("error getting proxy information")
- } else {
- reportId, err := policy_upstream.UploadSharedReport(report, os.Getenv(featureReportAlternateUrlEnv), proxy)
- if err != nil {
- log.Fatal().Err(err).Msg("could not upload report results")
- }
- fmt.Printf("View report at %s\n", reportId.Url)
- }
- }
-
  // if we had asset errors, we return a non-zero exit code
  // asset errors are only connection issues
  if report != nil {