Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 remove trailing dot for short cmd description #1049

Merged
merged 3 commits into from
Jan 16, 2024
Merged

🧹 remove trailing dot for short cmd description #1049

merged 3 commits into from
Jan 16, 2024

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Jan 15, 2024 •
edited
Loading

This PR simplifies the short descriptions and does not end with trailing dots

@chris-rock chris-rock marked this pull request as draft January 15, 2024 16:53
misterpantz
misterpantz reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully consistent :)

apps/cnspec/cmd/vuln.go Outdated Show resolved Hide resolved
@chris-rock chris-rock force-pushed the chris-rock/update-cmd-short-desc branch from 187ce0b to 2db66ed Compare January 16, 2024 19:52
@chris-rock chris-rock marked this pull request as ready for review January 16, 2024 19:52
@chris-rock chris-rock force-pushed the chris-rock/update-cmd-short-desc branch from 2db66ed to 63319b4 Compare January 16, 2024 19:52
misterpantz
misterpantz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@arlimus arlimus merged commit 3376dce into main Jan 16, 2024
9 checks passed
@arlimus arlimus deleted the chris-rock/update-cmd-short-desc branch January 16, 2024 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-rock @misterpantz @arlimus