Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 harmonize the version handling for mondoo.version #1129

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

chris-rock
Copy link
Member

The problem was that we have not set the cnquery version variables properly. The shell had special handling which I removed to ensure we have consistent results. This has not affected prod builds, just dev builds.

before

±> cnspec run -c "mondoo.version"
mondoo.version: "unstable"
±> cnspec shell -c "mondoo.version"
→ connected to macOS
  ___ _ __  ___ _ __   ___  ___ 
 / __| '_ \/ __| '_ \ / _ \/ __|
| (__| | | \__ \ |_) |  __/ (__ 
 \___|_| |_|___/ .__/ \___|\___|
   mondoo™     |_|              
mondoo.version: "v10.3.4"

after

±> cnspec run -c "mondoo.version"
mondoo.version: "v10.3.4"
±> cnspec shell -c "mondoo.version"
→ connected to macOS
  ___ _ __  ___ _ __   ___  ___ 
 / __| '_ \/ __| '_ \ / _ \/ __|
| (__| | | \__ \ |_) |  __/ (__ 
 \___|_| |_|___/ .__/ \___|\___|
   mondoo™     |_|              
mondoo.version: "v10.3.4"

Copy link
Contributor

Test Results

  1 files   24 suites   18s ⏱️
290 tests 289 ✅ 1 💤 0 ❌
291 runs  290 ✅ 1 💤 0 ❌

Results for commit a80ef6a.

@chris-rock chris-rock merged commit f00cf2b into main Feb 19, 2024
12 checks passed
@chris-rock chris-rock deleted the chris-rock/fix-version-handling branch February 19, 2024 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants