Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix junit reporter panic #1277

Merged
merged 1 commit into from
Apr 30, 2024
Merged

🐛 fix junit reporter panic #1277

merged 1 commit into from
Apr 30, 2024

Conversation

imilchev
Copy link
Member

The bundle can be empty if cnspec encountered an error during scanning. In that case, we need to make sure we don't exit with a panic

@imilchev
🐛 fix junit reporter panic
519ec6f 
Signed-off-by: Ivan Milchev <ivan@mondoo.com>
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  1 files  ±0   24 suites  ±0   16s ⏱️ ±0s
372 tests ±0  371 ✅ ±0  1 💤 ±0  0 ❌ ±0 
373 runs  ±0  372 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 519ec6f. ± Comparison against base commit 50fcabe.

czunker
czunker approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imilchev

@czunker czunker merged commit b719973 into main Apr 30, 2024
13 checks passed
@czunker czunker deleted the ivan/fix-junit-reporter-panic branch April 30, 2024 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czunker czunker czunker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imilchev @czunker