Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Auto approve go dep PRs by dependabot #1346

Merged
merged 2 commits into from
Jul 15, 2024
Merged

🤖 Auto approve go dep PRs by dependabot #1346

merged 2 commits into from
Jul 15, 2024

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jun 27, 2024

No description provided.

@czunker
🤖 Auto approve go dep PRs by dependabot
3771ab7 
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Move auto-approve into tests workflow
ef7752a 
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker force-pushed the czunker/auto_approve_gp_deps branch from 8708844 to ef7752a Compare July 12, 2024 17:31
@czunker
Copy link
Contributor Author

czunker commented Jul 12, 2024

The official docs suggest to put this into a separate trigger:
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#approve-a-pull-request

This is in the first commit of this PR.
But because of the nature how our tests are triggered, I had to add a sleep to ensure all tests are present. This felt wrong, so I moved the approval into the workflow. This will also help us in case we want to auto-approve other PRs later.

imilchev
imilchev approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we also include the provider cnquery update pr that we generate on cnquery release?

@czunker czunker merged commit 24bad2c into main Jul 15, 2024
6 checks passed
@czunker czunker deleted the czunker/auto_approve_gp_deps branch July 15, 2024 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imilchev imilchev imilchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czunker @imilchev