Allow overriding risk magnitudes #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
force-pushed
the
jdm/risk-magnitude-override
branch
2 times, most recently
from
2ec3464
to
449115e
Compare
czunker
reviewed
Jul 17, 2024
policy/cnspec_policy.proto
Outdated
| float magnitude = 71; | ||
| bool is_absolute = 72; | ||
| float deprecated_v11_magnitude = 71; | ||
| bool deprecated_v11_is_absolute = 72; |
There was a problem hiding this comment.
nit: Could you please add a comment what to use instead?
policy/cnspec_policy.proto
Outdated
| @@ -645,7 +653,7 @@ message ScoreDelta { | |||
| message ScoredRiskFactor { | |||
| string mrn = 1; | |||
| float risk = 2; | |||
| bool is_absolute = 3; | |||
There was a problem hiding this comment.
I know, we save a risk factor struct in the backend. Do you know whether it is this one? Would this break the unmarshal of already saved risk factors?
| } | ||
|
|
||
| if riskFactor.Action != explorer.Action_UNSPECIFIED { | ||
| existing.Action = riskFactor.Action |
There was a problem hiding this comment.
Perhaps an edge case:
Could the same risk factor be defined in multiple policies?
This line would then mean that the last non-unspecified action wins. Is this as it should be?
There was a problem hiding this comment.
ya, i think that problem already exists. But if its defined in the space policy it will win
jaym
force-pushed
the
jdm/risk-magnitude-override
branch
from
449115e
to
fe5e731
Compare
czunker
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding the risk magnitude for a risk and completely disabling a risk.
After #1352