🧹 Report checks by mrn when used by controls #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
force-pushed
the
jdm/control-query-rj
branch
from
d7c2b24
to
17cceb7
Compare
For frameworks reporting, we want the ability to display how checks scored for a control. We aggregate the information by check. In some cases, we have checks that have different MRNs but the same code. This makes it difficult to separate these. This change modifies the reporting structure for controls. We don't directly send the check score to the control. Instead, a new reporting job is inserted that reports to the query mrn. And then that reports to the control.
jaym
force-pushed
the
jdm/control-query-rj
branch
from
17cceb7
to
47ef148
Compare
preslavgerchev
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For frameworks reporting, we want the ability to display how checks scored for a control. We aggregate the information by check. In some cases, we have checks that have different MRNs but the same code. This makes it difficult to separate these. This change modifies the reporting structure for controls. We don't directly send the check score to the control. Instead, a new reporting job is inserted that reports to the query mrn. And then that reports to the control.