IX

mondrake · Aug 31, 2023 · a20f67d · a20f67d
1 parent c8f9180
commit a20f67d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Driver/Database/mysqli/TransactionManager.php b/src/Driver/Database/mysqli/TransactionManager.php
@@ -41,7 +41,7 @@ protected function rollbackClientSavepoint(string $name): bool {
       // because the transaction is no longer active. In this case we rollback
       // to root and cleanup.
       $this->connection->getClientConnection()->rollBack();
-      $this->resetStack();
+//      $this->resetStack();
       $this->setConnectionTransactionState(ClientConnectionTransactionState::Voided);
       $this->processPostTransactionCallbacks();
       return TRUE;

diff --git a/tests/src/Kernel/mysqli/TransactionTest.php b/tests/src/Kernel/mysqli/TransactionTest.php
@@ -96,9 +96,9 @@ public function testTransactionWithDdlStatement() {
       try {
         // Rollback the outer transaction.
         $transaction->rollBack();
-        // @see \Drupal\mysql\Driver\Database\mysql\Connection::rollBack()
-// @todo mysqli does not fail when rolling back and no transaction active.
-//        $this->fail('Rolling back a transaction containing DDL should produce a warning.');
+        // Note: Difference from MySQL.
+        // MySQLi does not fail when rolling back and no transaction active.
+        // $this->fail('Rolling back a transaction containing DDL should produce a warning.');
       }
       catch (Warning $warning) {
         $this->assertSame('Rollback attempted when there is no active transaction. This can cause data integrity issues.', $warning->getMessage());