Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2384 Script Clean Up #331

Merged
merged 18 commits into from
Aug 11, 2023
Merged

Conversation

blink1073
Copy link
Member

  • Remove portions of run-deployed-lambda-aws-tests.sh that have moved to setup/teardown scripts
  • Enforce input variables
  • Handle function failures and exit accordingly
  • Actually show the script logs

Tested with mongodb/mongo-python-driver#1310

Copy link
Contributor

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Note Durran is out until next week.

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073
Copy link
Member Author

I'll make a PR for Go as well (I'm the lead on that team). I had already made mongodb/mongo-go-driver#1329 to start using the individual scripts.

@blink1073
Copy link
Member Author

blink1073 commented Aug 2, 2023

Oh my, the Go tests were actually failing, which this change exposed. Working on a fix.

@blink1073
Copy link
Member Author

Okay, this is now passing in https://github.com/mongodb/mongo-go-driver/pull/1343/files as well. I didn't catch that there were two versions of run-deployed-lambda-aws-tests.sh. I think we should remove the old one in favor of the one in aws_lamba now that no one is using it.

Copy link
Contributor

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the old one in favor of the one in aws_lamba now that no one is using it.

SGTM should we do that in this PR?

@blink1073
Copy link
Member Author

I think we should remove it in this PR, WDYT @durran?

@durran
Copy link
Member

durran commented Aug 11, 2023

I think we should remove it in this PR, WDYT @durran?

Yes it was intentional to remove it and keep the one in aws_lambda so go for it.

@blink1073 blink1073 merged commit ce04f21 into mongodb-labs:master Aug 11, 2023
12 checks passed
@blink1073 blink1073 deleted the DRIVERS-2384 branch August 11, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants