-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2384 Script Clean Up #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Note Durran is out until next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a PR for Go as well (I'm the lead on that team). I had already made mongodb/mongo-go-driver#1329 to start using the individual scripts. |
Oh my, the Go tests were actually failing, which this change exposed. Working on a fix. |
Okay, this is now passing in https://github.com/mongodb/mongo-go-driver/pull/1343/files as well. I didn't catch that there were two versions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the old one in favor of the one in aws_lamba now that no one is using it.
SGTM should we do that in this PR?
I think we should remove it in this PR, WDYT @durran? |
Yes it was intentional to remove it and keep the one in aws_lambda so go for it. |
run-deployed-lambda-aws-tests.sh
that have moved to setup/teardown scriptsTested with mongodb/mongo-python-driver#1310