DRIVERS-2723: ensure atlas cluster names are unique #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Sep 14, 2023
| # - the string cannot be > 64 characters long, so we hash the name to shorten it and maintain its uniqueness (hashes do have collisions but infrequently | ||
| # enough that hashing suffices here) | ||
| # - we convert it to hex encoding because cluster names must be alphanumeric (hyphens are allowed) | ||
| transform="process.stdout.write(require('crypto').createHash('md5').update(process.argv[1]).digest().toString('hex'))" |
There was a problem hiding this comment.
I couldn't find a hashing CLI tool that would reliably be available across all distros in CI.
Node should be pre-installed on every distro.
durran
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Node patch run on affected variants: https://spruce.mongodb.com/version/6503802d32f417b863191cf2/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Just realised you already linked one and didn't need to start my own. :)
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous changes to make cluster names unique did not actually produce unique cluster names. each task id starts with the project name, so piping the task_id into
base64 | head -c 8produces the same string for each evergreen project.This PR does two things:
executionexpansion is also included, to ensure function names are unique across restartspatch in Node showing unique cluster names for both tasks that use these scripts in CI: https://spruce.mongodb.com/version/65035e55d6d80a62019a64bc/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC