Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address build failures due to Python 3 binary lookup #357

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Oct 2, 2023

Partially reverts some changes made in #352 concerning Python 3 binary lookup (motivated by a stray explicit call to python) to address build failures on some EVG distros where neither python nor python3 are available in default binary paths.

The Using Python3 binary: $PYTHON case added in #352 is preserved to avoid a redundant call to find_python3 when start-orchestration.sh is invoked via run-orchestration.sh (which already called find_python3). This might still break EVG builds that happen to set the PYTHON environment variable before invoking start-orchestration.sh directly (instead of through run-orchestration.sh) if PYTHON is set to a Python binary that is not 3.0+ or does not support venv. If that is the case, this too can be reverted to the prior unconditional call to find_python3.

@eramongodb eramongodb self-assigned this Oct 2, 2023
@blink1073
Copy link
Member

Test failure: find-python3.sh must be run in a Bash shell!

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eramongodb
Copy link
Contributor Author

Although the GitHub Actions config was updated to use shell: bash for consistency, the run-orchestration.sh script itself still uses #!/bin/sh for backwards-compatibility, as many DET users still run sh run-orchestration.sh. Making run-orchestration.sh require Bash would be a change far beyond the scope of this PR; therefore, a Bash subshell is used to run find_python3 instead. Documented this context with a comment prior to running find_python3.

@blink1073
Copy link
Member

Test failure is unrelated, was fixed in #356

@eramongodb eramongodb merged commit e31f785 into mongodb-labs:master Oct 2, 2023
13 of 15 checks passed
@eramongodb eramongodb deleted the det-python3 branch October 2, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants