Address build failures due to Python 3 binary lookup #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts some changes made in #352 concerning Python 3 binary lookup (motivated by a stray explicit call to
python
) to address build failures on some EVG distros where neitherpython
norpython3
are available in default binary paths.The
Using Python3 binary: $PYTHON
case added in #352 is preserved to avoid a redundant call tofind_python3
whenstart-orchestration.sh
is invoked viarun-orchestration.sh
(which already calledfind_python3
). This might still break EVG builds that happen to set thePYTHON
environment variable before invokingstart-orchestration.sh
directly (instead of throughrun-orchestration.sh
) ifPYTHON
is set to a Python binary that is not 3.0+ or does not support venv. If that is the case, this too can be reverted to the prior unconditional call tofind_python3
.