DRIVERS-2416 Add support for a second Azure client #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
matthewdale
approved these changes
Oct 21, 2023
.evergreen/auth_oidc/azure/test.py
Outdated
| @@ -8,11 +8,13 @@ | |||
| _AUTH_MAP["MONGODB-OIDC"] = _authenticate_oidc | |||
|
|
|||
| app_id = os.environ['AZUREOIDC_CLIENTID'] | |||
| client_id = os.environ['AZUREOIDC_TOKENCLIENT'] | |||
|
|
|||
| def callback(client_info, server_info): | |||
There was a problem hiding this comment.
Optional: The side effect of setting client_id on callback is fairly confusing. Is there any way to encode the new client_id requirement in the callback function, or in a callback creator function?
E.g.
def callback_for(app_id, client_id):
def callback(client_info, server_info):
...
return callbackThere was a problem hiding this comment.
Updated to use a closure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This infrastructure will be needed to support testing drivers with multiple clients on Azure. I tested it locally by running
create_and_update_vm.shand ensuring that the self-test passes.