DRIVERS-2543 Pull mongohouse image from ADL ECR repo #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ols into DRIVERS-2543
NoahStapp
requested changes
Nov 6, 2023
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
| # | |||
| # This script launches a docker-based for mongohoused for testing. | |||
There was a problem hiding this comment.
missing an "image" after "docker-based."
There was a problem hiding this comment.
Do we need this empty file?
There was a problem hiding this comment.
They aren't empty, I made them executable so it shows up as a 0 line change.
There was a problem hiding this comment.
Got it, the Github UI does not make that clear.
There was a problem hiding this comment.
Do we need this empty file?
.evergreen/auth_aws/setup_secrets.py
Outdated
| @@ -13,13 +13,17 @@ | |||
|
|
|||
| AWS_ROLE_ARN = "arn:aws:iam::857654397073:role/drivers-test-secrets-role" | |||
|
|
|||
| AWS_ROLE_ARN = "arn:aws:iam::857654397073:role/drivers-test-secrets-role" | |||
There was a problem hiding this comment.
Duplicate definition of AWS_ROLE_ARN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending https://github.com/10gen/mongohouse/pull/7602 we can remove the
test.yaml