DRIVERS-2328: Skip installing the legacy shell by default #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-2328
This PR removes the current
SKIP_LEGACY_SHELL
environment variable and introduces a newINSTALL_LEGACY_SHELL
variable to essentially flip the default behaviour.Recent work in the Go driver provides a template for drivers to remove usage of the legacy shell. The "Downstream Changes Summary" of the above ticket reads as follows:
If this approach sounds good, I would send the drivers ticket to implementation and add a timeline for this change to be merged. I would propose one month for this, as the change would allow drivers to keep using the legacy shell by adding
INSTALL_LEGACY_SHELL=1
to appropriate places before taking the time to remove legacy shell usage.